Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Webpack configuration #324

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Simplify Webpack configuration #324

merged 4 commits into from
Mar 24, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 24, 2017

Expands upon #321...

  • Further simplify entry configuration
  • Bump hpq dependency to v1.1.1 which resolves issue noted at Explicitly target entry modules #321 (comment) and avoids need to specifically target dependencies to be included in Babel transpilation

youknowriad
youknowriad approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtias mtias added the Framework Issues related to broader framework topics, especially as it relates to javascript label Mar 24, 2017
@aduth aduth force-pushed the update/webpack-entry-module branch from 9a8b554 to fa8cd1c Compare March 24, 2017 14:39
@aduth
Copy link
Member Author

aduth commented Mar 24, 2017

fa8cd1c flattens folder structure, effectively removing modules (moving its contents to top-level directory).

@aduth
Lint top-level directory
e161dca 
Ensures errors in e.g. webpack.config.js are flagged
@youknowriad
Copy link
Contributor

👍 for dropping the top level modules directory

@aduth aduth merged commit 8ab485f into master Mar 24, 2017
@aduth aduth deleted the update/webpack-entry-module branch March 24, 2017 14:53
@snyk-bot snyk-bot mentioned this pull request Jan 15, 2022
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Sep 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @youknowriad @mtias